Skip to content

Converted SequenceSampler from utility class to interface #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2022
Merged

Converted SequenceSampler from utility class to interface #298

merged 2 commits into from
Nov 18, 2022

Conversation

@cicirello
Copy link
Owner

@cicirello cicirello commented Nov 18, 2022

Summary

SequenceSampler converted from a utility class of static methods to an interface, retaining the existing static methods that use a default source of randomness, but introducing nextSample methods for classes to implement.

Closing Issues

Closes #277

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvements to existing code, such as refactoring or optimizations (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cicirello cicirello added enhancement New feature or request refactor labels Nov 18, 2022
@cicirello cicirello added this to the JPT 5.0.0 milestone Nov 18, 2022
@cicirello cicirello self-assigned this Nov 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

JaCoCo Test Coverage Summary Statistics

  • Coverage: 100%
  • Branches: 100%

@cicirello cicirello merged commit 1171ad6 into master Nov 18, 2022
@cicirello cicirello deleted the feat-seq-sampler-interface branch November 18, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cicirello cicirello

Labels

enhancement New feature or request refactor

Projects

Computational Intelligence Research
Status: Done

Milestone

JPT 5.0.0

Development

Successfully merging this pull request may close these issues.

Convert SequenceSampler to an interface

2 participants

@cicirello