Use proper helm value in CI clusters#8973
Merged
Merged
Conversation
Member
Author
|
test-me-please |
nebril
added
pending-review
area/CI
Member
Author
|
test-me-please |
brb
reviewed
Aug 21, 2019
| "agent.tag": "latest", | ||
| "global.tag": "latest", | ||
| "operator.image": "operator", | ||
| "operator.tag": "latest", |
Member
There was a problem hiding this comment.
Nice catch! Shouldn't we get rid of operator.tag as the operator Chart is using the global.tag to define the image tag?
Member
Author
There was a problem hiding this comment.
whoah, didn't see this one. Will add this to this PR
Member
There was a problem hiding this comment.
I think we should revisit all the options.
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/agent-tag-ci-fix
branch
from
0aa63e9 to
9c1c2dc
Compare
Member
Author
|
test-me-please |
brb
approved these changes
Aug 21, 2019
ianvernon
approved these changes
Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is