elf: drop legacy non-libbpf xdp* and seccomp attach types #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was never part of libbpf and there are no records of where it originated from or why it's still here. Migrating is quite straightforward, just change the function's section name to 'socket'. Signed-off-by: Timo Beckers <timo@isovalent.com>
… names The following section prefixes are now no longer supported: - xdp.frags_devmap/ - xdp_devmap/ - xdp.frags_cpumap/ - xdp_cpumap/ Due to XDP-related upstream changes addressed in a prior commit, now would be a good time to let go of the unofficial backwards compat sections. This brings ebpf-go back in line with libbpf, at least as far as XDP section names go. Signed-off-by: Timo Beckers <timo@isovalent.com>
We want to avoid deviating from libbpf behaviour when it comes to section naming, and the elfSectionDefs list was recently extended to ignore section name extras for struct_ops prog sections, which is not ideal. Use an explicit special case with a reference to the libbpf documentation instead. Remove the internal ignoreExtra flag and related code along with the override list. Document struct_ops.s. Signed-off-by: Timo Beckers <timo@isovalent.com>
dylandreimerink
approved these changes
Jan 14, 2026
Contributor
|
Thanks @ti-mo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're introducing some breaking changes regarding XDP ELF loading in #1919, this would be a good time to get rid of some section-related tech debt.
This PR deprecates the following section prefixes, bringing us back in line with libbpf:
For XDP, use the appropriate section names as documented in https://ebpf-go.dev/concepts/section-naming and https://docs.kernel.org/bpf/libbpf/program_types.html. For seccomp, change the section name to 'socket'.