hive: take Logger as part of Start/Stop or Run#3
Merged
joamaki merged 1 commit intocilium:mainfrom Apr 24, 2024
Merged
Conversation
Instead of having to provide a logger already at hive creation time, pass the logger to Start/Stop/Run, which is when the underlying cells actually need it. Also revert the changes to the Apply interface by passing the logger when the invokes are actually run instead of during apply. Finally, add hivetest.Logger to create a logger from a testing.TB, so that the logs can be attributed to the correct test when running tests in parallel. Unfortunately, t.Helper() doesn't correctly work in combination with slog - we log the real source location as an attribute as a workaround. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
bimmlerd
force-pushed
the
pr/bimmlerd/remove-default-logger
branch
from
7fe45e8 to
f70eb37
Compare
joamaki
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having to provide a logger already at hive creation time, pass the logger to Start/Stop/Run, which is when the underlying cells actually need it.
Also revert the changes to the Apply interface by passing the logger when the invokes are actually run instead of during apply.
Finally, add hivetest.Logger to create a logger from a testing.TB, so that the logs can be attributed to the correct test when running tests in parallel. Unfortunately, t.Helper() doesn't correctly work in combination with slog - we log the real source location as an attribute as a workaround.