Fix data race in cell.Config due to shared FlagSet#4
Merged
Conversation
This fixes and adds a regression test for a data race due to using a shared FlagSet
in cell.Config that was mutated due to e.g. (*FlagSet).AddFlag modifying the passed
in flag. This race occured in cases where a single Config cell was used in multiple
hives in parallel (e.g. by tests).
Previous write at 0x00c000111ea0 by goroutine 10:
github.com/spf13/pflag.(*FlagSet).AddFlag()
/home/jussi/go/pkg/mod/github.com/spf13/pflag@v1.0.5/flag.go:854 +0x153
The issue is fixed by creating the FlagSet during Apply() so each invocation
gets its own unshared set.
Reported-by: David Bimmler <david.bimmler@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
bimmlerd
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes and adds a regression test for a data race due to using a shared FlagSet in cell.Config that was mutated due to e.g. (*FlagSet).AddFlag modifying the passed in flag. This race occured in cases where a single Config cell was used in multiple hives in parallel (e.g. by tests).
The issue is fixed by creating the FlagSet during Apply() so each invocation gets its own unshared set.
Reported-by: David Bimmler david.bimmler@isovalent.com