chown: fix missing function on non-linux OS#6
Merged
1 commit merged intocilium:masterfrom Nov 16, 2024
Merged
Conversation
Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
glibsm
approved these changes
Nov 15, 2024
Member
glibsm
left a comment
glibsm
left a comment
There was a problem hiding this comment.
More platforms than just linux are capable of chown, but my priority is to be able to compile the go code on any platform without undefined error.
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5, we introduced a new
chownWithModefunc inchown_linux.goand forgot to add it as well for non-linux OS.CC @lambdanis