Merged
Conversation
Ran make tidy-fix locally, hopefully CI agrees. Added new make target tidy-fix-head that checks and fixes only the files modified in the HEAD commit. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Check all the modified C++ sources in the PR, not just in the last commit. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
sayboras
approved these changes
Feb 24, 2026
jrajahalme
added a commit
that referenced
this pull request
Feb 25, 2026
Do not set ref on PR checkout for tidy so that ref range HEAD^1 HEAD covers all the changes in the PR. Fixes: #1760 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added a commit
that referenced
this pull request
Feb 25, 2026
Do not set ref on PR checkout for tidy so that ref range HEAD^1 HEAD covers all the changes in the PR. Fixes: #1760 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dependency
@com_google_absl//absl/...as that caused build failures.Change CI clang tidy check ref range from HEAD only to all the commits in the PR.
Add a new make target
tidy-fix-headthat runs clang tidy fixes on the files modified on the head commit only. This is useful in local development where running clang tidy on unchanged files wastes a lot of time.First commit is factored out of #1754.