Add basic tests for stackwhere#4
Merged
dylandreimerink merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
dylandreimerink
force-pushed
the
feature/basic-tests
branch
2 times, most recently
from
48a0b28 to
5c505a9
Compare
There was a problem hiding this comment.
Pull request overview
Adds a small DWARF/BPF fixture and Go tests to validate stackwhere’s stack slot and total stack usage calculations, and wires the tests into CI.
Changes:
- Add
testdata/basic.cfixture (compiled tobasic.o) intended to exercise stack slot reuse and inlining. - Add Go unit tests for
getStackSlotUsageandgetProgramStackUsageusingtestdata/basic.o. - Extend GitHub Actions CI to run
go testand to enforce that generatedtestdataartifacts are up to date.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/Makefile | Adds commands to (re)build the BPF fixture object(s). |
| testdata/basic.c | Adds a C BPF fixture designed to produce predictable DWARF stack layout. |
| cmd/stackwhere/program_test.go | Adds a unit test for stack slot grouping from DWARF. |
| cmd/stackwhere/collection_test.go | Adds a unit test for total per-program stack usage. |
| .github/workflows/ci.yaml | Adds go test and a job to ensure testdata outputs are current. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This commit adds basic tests for stackwhere. We use a simple C file with a few functions and inlined functions to test the call stack functionality of stackwhere. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/basic-tests
branch
from
5c505a9 to
a2417a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds basic tests for stackwhere. We use a simple C file with a few functions and inlined functions to test the call stack functionality of stackwhere.