Skip to content

Implement On-Balance Volume (OBV) Strategy. Fixes #342#355

Merged
cinar merged 1 commit intomasterfrom
issue-342-obv-strategy
Apr 19, 2026
Merged

Implement On-Balance Volume (OBV) Strategy. Fixes #342#355
cinar merged 1 commit intomasterfrom
issue-342-obv-strategy

Conversation

@cinar
Copy link
Copy Markdown
Owner

@cinar cinar commented Apr 19, 2026

Describe Request

Implements the On-Balance Volume (OBV) trading strategy using the existing volume.Obv indicator.

This PR also includes:

  • A fix for a calculation bug in the OBV indicator where it was comparing the current closing price to the previous OBV value instead of the previous closing price.
  • Updated test data for the OBV indicator.
  • 100% test coverage for the new strategy.
  • Updated documentation.

Fixed #342

Signed-off-by: Onur Cinar <onur.cinar@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (2f2e411) to head (b990cbb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   93.06%   93.13%   +0.07%     
==========================================
  Files         214      215       +1     
  Lines        6127     6190      +63     
==========================================
+ Hits         5702     5765      +63     
  Misses        344      344              
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cinar cinar merged commit e86d913 into master Apr 19, 2026
5 checks passed
@cinar cinar deleted the issue-342-obv-strategy branch April 19, 2026 19:58
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement On-Balance Volume (OBV) Strategy

2 participants