Keltner Channel Strategy added. Issue 339#362
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 93.21% 93.24% +0.03%
==========================================
Files 219 220 +1
Lines 6311 6355 +44
==========================================
+ Hits 5883 5926 +43
- Misses 347 348 +1
Partials 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thank you very much for your contribution. If you can sign your commit, I will be able to merge it. Otherwise the repo policy is not allowing me to do so. Otherwise, your changes are all good. |
Signed-off-by: Eonyak Cho <eonyakcho@gmail.com>
df58fd0 to
5ce679f
Compare
Contributor
Author
|
Hi, Thank you for reviewing my PR. |
Signed-off-by: Onur Cinar <onur.cinar@gmail.com>
Owner
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Request
Implements the Keltner Channel Strategy as requested in issue #339.
The Keltner Channel indicator already exists in the
volatilitypackage. This PR adds the strategy layer on top of it, following the existing patterns instrategy/volatility.Fixed #339
Change Type
New strategy.