Conversation
- Add Fallback support to the retry execution loop in retry.go. - Implement WithFallback and WithFallbackErr functional options in options.go. - Add comprehensive unit tests in fallback_test.go to verify fallback logic. - Update docs/SPEC.md and README.md with fallback strategy documentation. - Add a practical fallback example in examples/fallback/main.go. - Improve code coverage to 100% for the core package.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 74.49% 73.17% -1.32%
==========================================
Files 11 12 +1
Lines 345 384 +39
==========================================
+ Hits 257 281 +24
- Misses 82 101 +19
+ Partials 6 2 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add Fallback support to the retry execution loop in retry.go.
Implement WithFallback and WithFallbackErr functional options in options.go.
Add comprehensive unit tests in fallback_test.go to verify fallback logic.
Update docs/SPEC.md and README.md with fallback strategy documentation.
Add a practical fallback example in examples/fallback/main.go.
Improve code coverage to 100% for the core package.
Fixes Policy Composition & Fallbacks #8
New Feature