Isolating attribution and if condition#1941
Closed
cpsw wants to merge 1 commit into
Closed
Conversation
I'm suggesting a code style change that I would use in my code.
Contributor
|
Not sure I understand your style argument, but doesn't this create an infinite loop? |
Author
|
I was trying to make the assignment explicit, but you are right, @MikeGitb. I'm sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm suggesting a code style change that I would use in my code. I heard some discussions about this issue, and I would like to suggest it to see if it is more a personal preference or whether it makes sense.
It is just to make explicit that an assignment expression has the value of the left operand after the assignment.