fix(sf): convert L4504 preflight guard from hard-skip to dry-execution#373
Merged
Conversation
Follow-up to #372 (merged), which shipped the hard-skip CheckShellRunSkipDirector Choice gate. Per the chosen approach, convert it to keystone-consistent dry- execution so the Friday preflight still exercises the ReportCard + Director Lambda bootstrap/import/IAM/transport paths instead of skipping them (the shell- run keystone deliberately removed all skip-exceptions). - Remove the CheckShellRunSkipDirector Choice; restore the direct WaitForWeeklySubstrateHealthCheck -> ReportCard edge. - Thread dry_run.$=$.research_dry into the ReportCard + Director payloads (the canonical shell-run-dry signal; false on the real Saturday run / true on the preflight), mirroring the eval-judge / rationale-clustering / replay-concordance / counterfactual advisory Lambdas. Handlers (companion alpha-engine-evaluator #23): ReportCard dry -> no-write (still boots/imports/reads/computes); Director dry -> no-Opus / no-write probe (constructs the real client to validate the langchain import + SSM key-fetch IAM grant, reads the ledger, stops short of .invoke(), mutates nothing — the shared non-date-scoped carry-over ledger is never polluted). Tests updated to expect the dry-execution wiring + test_advisory_tail_runs_dry_on_preflight + payload-key registry. 497 SF-structure tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #372 (merged). #372 shipped the hard-skip
CheckShellRunSkipDirectorChoice gate; this converts it to the chosen dry-execution approach so the Friday preflight exercises the advisory Lambdas' bootstrap/import/IAM paths rather than skipping them (the shell-run keystone deliberately removed all skip-exceptions). Companion handler PR: alpha-engine-evaluator #23.Changes
CheckShellRunSkipDirectorChoice; restore the directWaitForWeeklySubstrateHealthCheck → ReportCardedge."dry_run.$": "$.research_dry"into theReportCard+Directorpayloads — the canonical shell-run-dry signal (seededfalseinInitializeInput, flippedtrueinApplyShellRunDefaults), mirroring the eval-judge / rationale-clustering / replay-concordance / counterfactual advisory Lambdas.On a preflight both states now run dry (ReportCard: no-write; Director: no-Opus/no-write probe validating the langchain import + SSM key-fetch IAM grant + ledger read) — they are not skipped.
Tests
→ ReportCardedge; replaced the skip test withtest_advisory_tail_runs_dry_on_preflight(assertsdry_run.$=$.research_dryon both payloads)._SATURDAY_PAYLOAD_KEYSregistry.Deploy note
SF auto-deploys on merge to
main(data #371--definition file://fix clears the prior ARG_MAX). Land together with evaluator #23 (the SF references the handlerdry_runcontract).🤖 Generated with Claude Code