Add daily_data to _UPSTREAM_MAX_AGE_H (belt-and-suspenders with #53)#54
Merged
Conversation
Adds daily_data: 26 to _UPSTREAM_MAX_AGE_H. Pairs with the stamp emission added in alpha-engine-data#41 — belt-and-suspenders with the direct LastModified check from #53: - Stamp (this PR's gate): catches "ran and failed today" with structured status/error/summary - LastModified (#53): catches "stamp green, blob stale" Both fire hard-fail + Telegram from main.py's existing upstream gate and the #53 freshness block respectively. Deploy order: alpha-engine-data#41 must merge AND run at least once (next weekday 13:05 UTC) before this merges, otherwise every executor run fails with "no health data returned" until daily_data writes its first stamp. 26h matches predictor_inference's grace buffer — same weekday cadence. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the stamp-side of the belt-and-suspenders daily-data freshness architecture:
The stamp alone is insufficient — producer self-reporting can lie. The LastModified check alone misses structured failure state. Having both closes both holes.
Change
One-liner in `executor/main.py:894` — adds `"daily_data": 26` to `_UPSTREAM_MAX_AGE_H`. 26h matches `predictor_inference` since both run at the same weekday 13:05 UTC cadence.
Deploy order — IMPORTANT
If this merges first, every executor run hard-fails with `daily_data: no health data returned` until DataPhase1 emits its first stamp. Keep this PR blocked until #41 has deployed AND been exercised on a weekday.
Pairs with
Test plan
🤖 Generated with Claude Code