Conversation
…SiteSettingsPage and VerificationModal for consistency and improved styling
…d padding for improved responsiveness
…se CSS variables for improved theming consistency
…ple components for improved readability
…for improved styling and consistency
…nent for improved layout consistency
…proved layout consistency
…mponents for improved visual feedback
…installation pages for improved visual consistency
…stency with new branding
…visual consistency
…nts across various components
Greptile SummaryThis PR implements comprehensive design consistency improvements across the Pulse frontend, successfully aligning 35 files with the Ciphera design system. The changes are well-structured and focus on standardization without introducing breaking changes. Key improvements:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| components/dashboard/Chart.tsx | Replaced hardcoded hex colors with CSS variables, standardized gaps and spacing, added shadow transitions |
| components/settings/OrganizationSettings.tsx | Updated domain to pulse.ciphera.net, added dark mode variants, standardized padding and gaps, removed max-w-4xl container |
| components/sites/VerificationModal.tsx | Replaced custom buttons with Button component from @ciphera-net/ui |
| app/sites/[id]/settings/page.tsx | Replaced custom buttons with Button component, updated container to max-w-6xl, standardized padding, added dark mode variants |
| app/features/page.tsx | Standardized H1 to text-4xl md:text-5xl and H2s to text-2xl font-bold, updated card padding to p-6 |
| components/dashboard/WorldMap.tsx | Replaced hardcoded colors with CSS variables, standardized negative margin value |
| app/sites/[id]/funnels/[funnelId]/page.tsx | Replaced hardcoded colors with CSS variables, added shadow transitions, added dark mode variants |
| package.json | Bumped version to 0.10.0-alpha and updated @ciphera-net/ui to 0.0.58 |
Last reviewed commit: 1a97027
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item
PULSE-59
Summary
/toolsreferenceChanges
Typography:
text-4xl md:text-5xlfor marketing H1s (integrations, changelog, features, welcome)text-4xl md:text-6xl→text-4xl md:text-5xl; H2s →text-2xl font-boldButtons:
<button>with<Button>from@ciphera-net/uiin Site Settings (3), VerificationModal (3), Pricing Enterprise (1)Containers:
max-w-6xlacross org-settings, settings, site-settings, sites, sites/new, notificationsmax-w-4xlfrom OrganizationSettings and ProfileSettings (ciphera-ui)Colors:
var(--color-brand-orange), etc.)bg-neutral-900/bg-neutral-800in integrations + installation pagesDark mode:
dark:variants across OrganizationSettings, site settings, PricingSection, funnels pagePadding & spacing:
p-6(~30 instances)pt-12→pt-20(4 static pages + IntegrationGuide.tsx)gap-1.5→gap-2,gap-2.5→gap-3,gap-0.5→gap-1(19 instances)Tailwind:
text-[10px]/text-[11px]→text-xs,gap-[2px]→gap-0.5,rounded-[2px]→rounded-sm,h-[320px]→h-80,min-w-[160px]→min-w-40,mt-[-10px]→-mt-2.5Shadows:
transition-shadow duration-300to 7 shadow elements across Chart, Funnels, Share, Uptime, OfflineBannerCopy & cleanup:
drop.ciphera.net/→pulse.ciphera.net/**Tools:** UtmBuilderfrom DESIGN_SYSTEM.mdciphera-ui:
max-w-4xlwrapper for full-width layoutTest Plan
max-w-6xlwidthpt-20)pulse.ciphera.net/in Org Settings → General