Skip to content
This repository was archived by the owner on Jan 27, 2023. It is now read-only.

Add CipherStash::Client.login class method#23

Merged
CDThomas merged 2 commits intomainfrom
add-log-in-method
Sep 27, 2022
Merged

Add CipherStash::Client.login class method#23
CDThomas merged 2 commits intomainfrom
add-log-in-method

Conversation

@CDThomas
Copy link
Contributor

@CDThomas CDThomas commented Sep 27, 2022

This PR adds a CipherStash::Client.login method for ActiveStash to use to perform logins.

See the docs in the diff for details.

Related ActiveStash PR: cipherstash-archive/activestash#87.

@CDThomas CDThomas requested a review from a team as a code owner September 27, 2022 05:15
@CDThomas CDThomas changed the title Add CipherStash::Client.log_in class method Add CipherStash::Client.log_in class method Sep 27, 2022
Copy link
Contributor

@freshtonic freshtonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question and a nit.

This is consistent with the name of the Rake task in ActiveStash.
@CDThomas CDThomas changed the title Add CipherStash::Client.log_in class method Add CipherStash::Client.login class method Sep 27, 2022
@CDThomas CDThomas merged commit 57f6efb into main Sep 27, 2022
@CDThomas CDThomas deleted the add-log-in-method branch September 27, 2022 22:35
freshtonic pushed a commit that referenced this pull request Dec 15, 2022
Add `CipherStash::Client.login` class method
freshtonic pushed a commit that referenced this pull request Dec 15, 2022
Add `CipherStash::Client.login` class method
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants