This repository was archived by the owner on Jan 27, 2023. It is now read-only.
Update put stream to handle bi directional stream#25
Merged
Conversation
fimac
force-pushed
the
put-stream-bi-direction
branch
3 times, most recently
from
e249d46 to
cf9436f
Compare
fimac
force-pushed
the
put-stream-bi-direction
branch
2 times, most recently
from
283c825 to
52214e3
Compare
fimac
force-pushed
the
put-stream-bi-direction
branch
from
52214e3 to
7497c7c
Compare
CDThomas
reviewed
Oct 16, 2022
Co-authored-by: Drew Thomas <7672425+CDThomas@users.noreply.github.com>
Co-authored-by: Drew Thomas <7672425+CDThomas@users.noreply.github.com>
Co-authored-by: Drew Thomas <7672425+CDThomas@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @CDThomas , I've addressed your comments. |
freshtonic
pushed a commit
that referenced
this pull request
Dec 15, 2022
Update put stream to handle bi directional stream
freshtonic
pushed a commit
that referenced
this pull request
Dec 15, 2022
Update put stream to handle bi directional stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the grpc client to use the latest version.
Updates the put_stream method to use the bi_directional endpoint. This returns an enumerable when called, which is then looped through to log each response, which has the current count of the total number inserted.
Testing done:
Have tested using this branch of the benchmark repo. Pointing the gemfile to a local version of active stash and this branch of the ruby client.
Results below are via running this on an EC2 instance.
I have also tested via this branch which has been updated with an E2E test for streaming upsert and error handling on a unique constraint.
Running the below command, with this ruby client branch checked out.
CS_SERVICE_PORT=50001 RUBYLIB=/users/fionamccawley/cipherstash/ruby-client/lib ./run.sh dev-local 0The active stash smoke test is failing due to an mismatch in ruby client versions. Looks like we need to do a release of ActiveStash so the latest update including the bump in versions is avaialble.