Skip to content

Comments

[BACKPLANE-1084] tidy up #56

Merged
neeasade merged 5 commits intomasterfrom
backplane-1236-bond
May 5, 2021
Merged

[BACKPLANE-1084] tidy up #56
neeasade merged 5 commits intomasterfrom
backplane-1236-bond

Conversation

@neeasade
Copy link
Contributor

@neeasade neeasade commented May 4, 2021

  • add linting
  • conform test namespace layout
  • add CODEOWNERS
  • kaocha

@neeasade neeasade force-pushed the backplane-1236-bond branch from 20d1cd9 to 8d91eaf Compare May 4, 2021 17:23
also use the codecov orb for the uploading
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #56 (7e46b71) into master (8a7a593) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files           2        2           
  Lines          81       81           
  Branches        1        1           
=======================================
  Hits           80       80           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7a593...7e46b71. Read the comment docs.

@neeasade neeasade requested a review from a team May 4, 2021 19:28
@neeasade neeasade merged commit 1c88636 into master May 5, 2021
when: always
command: lein cloverage --codecov
- codecov/upload:
file: target/coverage/codecov.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neeasade this comment got resolved but not addressed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad (slow down) --> #57

@neeasade neeasade changed the title [BACKPLANE-1236] tidy up [BACKPLANE-1084] tidy up May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants