Refactor builds and Dockerfiles#98
Merged
christian-stephen merged 2 commits intomainfrom Dec 20, 2024
Merged
Conversation
| env: [CGO_ENABLED=0] | ||
| goos: [linux] | ||
| goarch: [amd64, arm64] | ||
| goarch: [amd64] |
Member
Author
There was a problem hiding this comment.
We don't use arm64 for the fake task-agent, so no need to target it.
| FROM scratch AS builder | ||
|
|
||
| ARG ARCH | ||
| ARG TARGETPLATFORM |
Member
Author
There was a problem hiding this comment.
Automatically populated with the value of --platform.
ryanwohara
approved these changes
Dec 20, 2024
christian-stephen
force-pushed
the
cs/builds
branch
from
a907b53 to
d31de9f
Compare
christian-stephen
force-pushed
the
cs/builds
branch
from
304bfd0 to
9127988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
⚙️ Change Description
Acceptance Criteria:
✅ Solution
❓ Testing
📖 Documentation Updates