You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been following arc-node from the outside for a while now and reviewing PRs and issues as they come up — #299, #306, #307, #308, #309, #310, and the CI OOM report in #298. Rather than continue doing that unprompted, I wanted to make a straightforward offer.
If a review or a second assessment would ever be useful to you — on a PR, an issue, or a broader repo change — please feel free to tag @osr21 and I'll do my best to help.
On approach: I try to bring verification rather than opinion. In practice that means checking upstream commit containment against the reth pin rather than trusting a linked PR, testing merge order against the other open PRs before claiming a conflict, and confirming behaviour against live RPC or on-chain state before asserting it. On #309 that meant bisecting a curl regression by commit containment to establish exactly which versions were affected; on #306, establishing that a version pin was actively wrong rather than merely stale.
One thing I'd like to acknowledge directly: I posted a long assessment on #310 while it was still a draft. That was the wrong moment for a comment of that length, and I have no complaint about it being tidied away. Going forward I'll keep to the normal etiquette — nothing on drafts, inline review threads rather than long top-level comments, and scoped strictly to what I've actually verified.
If it's ever useful to add me formally as a reviewer, I'd be glad to be added. I appreciate that org settings often restrict review requests to members and outside collaborators, so if that isn't possible, a simple @-mention works just as well and requires nothing on your side.
Either way, thank you for the work on the repo — the recent CI and documentation cleanups have been good to follow. Entirely your call, and no issue at all if you'd prefer not.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Hi @romac,
I've been following arc-node from the outside for a while now and reviewing PRs and issues as they come up — #299, #306, #307, #308, #309, #310, and the CI OOM report in #298. Rather than continue doing that unprompted, I wanted to make a straightforward offer.
If a review or a second assessment would ever be useful to you — on a PR, an issue, or a broader repo change — please feel free to tag @osr21 and I'll do my best to help.
On approach: I try to bring verification rather than opinion. In practice that means checking upstream commit containment against the reth pin rather than trusting a linked PR, testing merge order against the other open PRs before claiming a conflict, and confirming behaviour against live RPC or on-chain state before asserting it. On #309 that meant bisecting a curl regression by commit containment to establish exactly which versions were affected; on #306, establishing that a version pin was actively wrong rather than merely stale.
One thing I'd like to acknowledge directly: I posted a long assessment on #310 while it was still a draft. That was the wrong moment for a comment of that length, and I have no complaint about it being tidied away. Going forward I'll keep to the normal etiquette — nothing on drafts, inline review threads rather than long top-level comments, and scoped strictly to what I've actually verified.
If it's ever useful to add me formally as a reviewer, I'd be glad to be added. I appreciate that org settings often restrict review requests to members and outside collaborators, so if that isn't possible, a simple @-mention works just as well and requires nothing on your side.
Either way, thank you for the work on the repo — the recent CI and documentation cleanups have been good to follow. Entirely your call, and no issue at all if you'd prefer not.
Best,
osr21
All reactions