Skip to content

feat(code)!: Decouple Host messages from Consensus actor#1109

Merged
romac merged 9 commits intomainfrom
romac/host-no-consensus-ref
Jul 23, 2025
Merged

feat(code)!: Decouple Host messages from Consensus actor#1109
romac merged 9 commits intomainfrom
romac/host-no-consensus-ref

Conversation

@romac
Copy link
Copy Markdown
Contributor

@romac romac commented Jun 26, 2025

Closes: #XXX


PR author checklist

For all contributors

For external contributors

@romac romac changed the title feat!(code): Decouple Host messages from Consensus actor feat(code)!: Decouple Host messages from Consensus actor Jun 26, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 82.25806% with 11 lines in your changes missing coverage. Please review.

Project coverage is 75.21%. Comparing base (1ff5b8c) to head (a269d47).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   75.56%   75.21%   -0.35%     
==========================================
  Files         170      170              
  Lines       17945    17932      -13     
  Branches    17945    17932      -13     
==========================================
- Hits        13560    13487      -73     
- Misses       3498     3570      +72     
+ Partials      887      875      -12     
Flag Coverage Δ
integration 75.01% <82.26%> (-0.36%) ⬇️
mbt 7.67% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 82.44% <ø> (-0.02%) ⬇️
engine 72.23% <93.94%> (+0.16%) ⬆️
app 85.46% <64.71%> (-1.44%) ⬇️
starknet 73.45% <70.00%> (-0.10%) ⬇️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 26, 2025

✅ Semver Check Passed

Great job! All semver violations have been resolved. This PR now complies with semantic versioning rules.

If you made version updates, please ensure that:

  • The version in Cargo.toml accurately reflects the nature of your changes
  • Any breaking changes are properly documented in BREAKING_CHANGES.md

@romac romac force-pushed the romac/host-no-consensus-ref branch from ecb7746 to 6048662 Compare June 26, 2025 11:29
@romac romac requested a review from sergio-mena July 9, 2025 12:58
Comment thread code/crates/app-channel/src/connector.rs Outdated
Comment thread code/crates/engine/src/consensus.rs
Comment thread code/crates/engine/src/host.rs
Comment thread code/crates/engine/src/host.rs
Comment thread code/crates/starknet/host/src/actor.rs
Comment thread code/crates/starknet/host/src/actor.rs
Copy link
Copy Markdown
Contributor

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes. They will simplify the readability of TestConsensus in Muppet 🚀

@romac romac requested a review from sergio-mena July 21, 2025 15:15
@romac romac marked this pull request as ready for review July 21, 2025 15:15
@romac romac requested review from adizere and ancazamfir as code owners July 21, 2025 15:15
Signed-off-by: Romain Ruetschi <romain@informal.systems>
@romac
Copy link
Copy Markdown
Contributor Author

romac commented Jul 23, 2025

@ancazamfir @hvanz Any concerns with merging this?

@ancazamfir
Copy link
Copy Markdown
Contributor

@ancazamfir @hvanz Any concerns with merging this?

Looks good!

@romac romac added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit bbb5fbe Jul 23, 2025
24 checks passed
@romac romac deleted the romac/host-no-consensus-ref branch July 23, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants