feat(code)!: Decouple Host messages from Consensus actor#1109
Merged
Conversation
Host messages from Consensus actorHost messages from Consensus actor
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
- Coverage 75.56% 75.21% -0.35%
==========================================
Files 170 170
Lines 17945 17932 -13
Branches 17945 17932 -13
==========================================
- Hits 13560 13487 -73
- Misses 3498 3570 +72
+ Partials 887 875 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
✅ Semver Check PassedGreat job! All semver violations have been resolved. This PR now complies with semantic versioning rules. If you made version updates, please ensure that:
|
ecb7746 to
6048662
Compare
sergio-mena
reviewed
Jul 10, 2025
sergio-mena
reviewed
Jul 10, 2025
sergio-mena
reviewed
Jul 10, 2025
sergio-mena
reviewed
Jul 10, 2025
sergio-mena
reviewed
Jul 10, 2025
sergio-mena
reviewed
Jul 10, 2025
sergio-mena
approved these changes
Jul 10, 2025
Contributor
sergio-mena
left a comment
There was a problem hiding this comment.
I like these changes. They will simplify the readability of TestConsensus in Muppet 🚀
Signed-off-by: Romain Ruetschi <romain@informal.systems>
Contributor
Author
|
@ancazamfir @hvanz Any concerns with merging this? |
Contributor
Looks good! |
ancazamfir
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
PR author checklist
For all contributors
RELEASE_NOTES.mdif the change warrants itBREAKING_CHANGES.mdif the change warrants itFor external contributors