Split out rel8-internal package#405
Merged
Merged
Conversation
TeofilC
changed the title
This new internal package will be versioned along with rel8. Each version of rel8 will support exactly one version of the internal package. We have chosen to use a separate package rather than an internal sublibrary since sublibraries don't have perfect support from tooling yet. We have temporarily not exposed the new Table.Verify module as it will be exposed from a new rel8-schema package.
TeofilC
changed the title
ocharles
approved these changes
Jun 29, 2026
ocharles
left a comment
ocharles
left a comment
Contributor
There was a problem hiding this comment.
There's a lot in this PR so I haven't reviewed anything - is there anything you want me to review in particular, or am I ok trusting it's just a mechanical change?
Contributor
Author
|
Yeah it's just a mechanical change. I think the main thing is whether it should be a new package or just a sublib. I've gone with a new package here cause people have mentioned to me that sublib support isn't perfect yet, but if you'd prefer a sublib we can go with that. |
Contributor
|
No preference, so happy with this as the work has been done! |
Contributor
Author
|
Cool thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new internal package will be versioned along with rel8.
Each version of rel8 will support exactly one version of the internal package.
We have chosen to use a separate package rather than an internal sublibrary
since sublibraries don't have perfect support from tooling yet.
We have temporarily not exposed the new Table.Verify module as it will
be exposed from a new rel8-schema package.