Run mypy during pre-commit #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I suspect that there may be potential practical uses for this in scientific applications that are sensitive to floating point math limitations. I plan to test it with a multivariable polynomial curve fitting algorithm where the conversion formula requires significantly more precision than the sensor input data. |
adafruit-adabot
added a commit
to adafruit/CircuitPython_Community_Bundle
that referenced
this pull request
Jun 9, 2022
Updating https://github.com/jepler/Jepler_CircuitPython_udecimal to 1.0.6 from 1.0.5: > Merge pull request circuitpython/Jepler_CircuitPython_udecimal#16 from jepler/pre-commit-ci-update-config > Merge pull request circuitpython/Jepler_CircuitPython_udecimal#14 from jepler/pre-commit-ci-update-config > Merge pull request circuitpython/Jepler_CircuitPython_udecimal#13 from jepler/pre-commit-mypy > Merge pull request circuitpython/Jepler_CircuitPython_udecimal#12 from jepler/pre-commit.ci > Merge pull request circuitpython/Jepler_CircuitPython_udecimal#11 from jepler/update-black-ci-etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on https://jaredkhan.com/blog/mypy-pre-commit this adds mypy (non-strict) during pre-commit. It might be useful in considering how we can apply this to CircuitPython libraries.
This means that the pre-commit file would always be different between projects, which is 👎
Using a separate script as suggested at https://jaredkhan.com/blog/mypy-pre-commit might make still allow the pre-commit-confg file to remain identical across libs; it could
pip install -r requirements_dev.txtand figure out the package name somehow (we must have that somewhere already)