Skip to content

Bug fixes and updates for mobile #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Bug fixes and updates for mobile #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48cd4d6
Bug fixes and updates for mobile
makermelissa Oct 26, 2021
d2fb960
Fixed Run and Restart buttons, optimizations
makermelissa Oct 27, 2021
e8f9763
Nudging after publishing update
makermelissa Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 138 additions & 37 deletions assets/css/style.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion assets/css/style.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 20 additions & 13 deletions assets/js/file_dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ class FileDialog {
async _openFolder(path) {
const fileList = this._currentModal.querySelector("#file-list");
const okButton = this._currentModal.querySelector("button.ok-button");
const fileName = this._currentModal.querySelector("#filename");
this._removeAllChildNodes(fileList);
if (path !== undefined) {
this._currentPath = path;
Expand All @@ -167,6 +168,7 @@ class FileDialog {
} catch(e) {
console.log(e);
}
fileName.value = "";
okButton.disabled = true;
}

Expand Down Expand Up @@ -218,26 +220,31 @@ class FileDialog {

async _openItem(item) {
const fileNameField = this._currentModal.querySelector("#filename");
const fileList = this._currentModal.querySelector("#file-list");
let filetype, filename;
let selectedItem = null;

// Loop through items and see if any have data-selected
for (let listItem of fileList.childNodes) {
if ((/true/i).test(listItem.getAttribute("data-selected"))) {
selectedItem = listItem;
}
}

if (item !== undefined) {
filetype = item.getAttribute("data-type");
filename = item.querySelector("span").innerHTML;
} else if (this._validFilename(fileNameField.value)) {
filename = fileNameField.value;
filetype = "text";
} else {
// Loop through items and see if any have data-selected
const fileList = this._currentModal.querySelector("#file-list");
for (let listItem of fileList.childNodes) {
if ((/true/i).test(listItem.getAttribute("data-selected"))) {
item = listItem;
}
}
if (item !== undefined) {
filetype = item.getAttribute("data-type");
filename = item.querySelector("span").innerHTML;
if (selectedItem !== null && fileNameField.value != selectedItem.querySelector("span").innerHTML) {
filetype = selectedItem.getAttribute("data-type");
filename = selectedItem.querySelector("span").innerHTML;
} else {
filename = fileNameField.value;
filetype = "text";
}
} else if (selectedItem !== null) {
filetype = selectedItem.getAttribute("data-type");
filename = selectedItem.querySelector("span").innerHTML;
}

if (filename !== undefined && filetype !== undefined) {
Expand Down
21 changes: 21 additions & 0 deletions assets/js/header_mobile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
document.addEventListener('DOMContentLoaded', function() {
document.getElementById('mobile-menu-button').addEventListener('click', handleMobileToggle);
document.querySelectorAll('#mobile-menu-contents li a').forEach((element) => {
element.addEventListener('click', handleMobileToggle);
});
});

function handleMobileToggle(event) {
event.preventDefault();

var menuContainer = document.getElementById('mobile-menu-contents');

menuContainer.classList.toggle('hidden');

var menuIcon = document.querySelector('#mobile-menu-button > i');
if (menuContainer.classList.contains('hidden')) {
menuIcon.classList.replace('fa-times', 'fa-bars');
} else {
menuIcon.classList.replace('fa-bars', 'fa-times');
}
}
Loading