Persistent Worker: fix context propagation to the agent #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses context propagation issues by ensuring that the agent always receives a valid W3C trace context, even when agentAwareTask.Traceparent and Tracestate are empty. Key changes include:
- Removing traceparent and tracestate parameters from runTask.
- Injecting a trace context into a MapCarrier using propagation.TraceContext{}.Inject.
- Updating the environment configuration to obtain trace values directly from the MapCarrier.
fkorotkov
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agentAwareTask.TraceparentandagentAwareTask.Tracestatecan be empty, which will result in agent not configuring it's trace context.By using
Inject()and reading results from themapCarrier, we always get some kind of trace context.