-
Notifications
You must be signed in to change notification settings - Fork 336
Issue 1096: bump module dependencies #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
buidav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
A couple of PS Linter errors to address.
Will approve after the liner errors are addressed. As a follow up to this PR:
- Bump the PowerShell versions that need bumping. This workflow should take care of that just attach it to a PR.
- Add in the code to create a Pull Request automatically
https://github.com/cisagov/ScubaGear/blob/62202709b63d425fcb8ac7c79dcd5ff0f0e5d8a7/utils/workflow/Set-ScubaGearModuleVersion.psm1#L62
|
@buidav and @mitchelbaker-cisa This PR should be good to go now. I resolved the PS issues and updated the workflow to create a PR when it is successfully run. |
mitchelbaker-cisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Create BumpPsDependencies.ps1 * Create ps_dependencies_requiredversionsfile.yaml * Update RequiredVersions.ps1 * Update RequiredVersions.ps1 * Update RequiredVersions.ps1 * Update RequiredVersions.ps1 * Update ps_dependencies_requiredversionsfile.yaml Add smoke test * Update ps_dependencies_requiredversionsfile.yaml * Update ps_dependencies_requiredversionsfile.yaml to add smoke test * Update RequiredVersions.ps1 due to missing module info * Update RequiredVersions.ps1 * Update BumpPsDependencies.ps1 * Update BumpPsDependencies.ps1 Updated Null * Update BumpPsDependencies.ps1 * Update ps_dependencies_requiredversionsfile.yaml to add PR * Update RequiredVersions.ps1 * Update ps_dependencies_requiredversionsfile.yaml
🗣 Description
Currently we are having to manually check for version updates for our PowerShell dependencies.
This issue is to create a GitHub action to automatically bump our PowerShell dependency versions.
Since there is no dependabot for PowerShell this workflow has to be custom made.
This change implements a workflow for updating the MaximumVersion of all the modules in the PowerShell/ScubaGear/RequiredVersions.ps1 file. A new branch is created if an update is made to the ps1 file. Smoke Test passed, except for pnp module due to it not loading properly.
💭 Motivation and context
Closes 1096 https://github.com//issues/1096🧪 Testing
My tests were successfull, yes anyone can test it. Forked main from CISA and updated files in the fork. Also created a branch and tested it there. Tested the workflows manually and then had them run automatically at midnight. Updates to the dependency files were made successfully in both cases. Ran ScubaGear after the changes were made, no issues seen. N/A✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branchbutton below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Mediumor larger)✅ Post-merge checklist