Update CISA URLs used in tests #25
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy subdomain rules.ncats.cyber.dhs.gov is now an alias of the preferred rules.vm.cyber.dhs.gov subdomain.
dav3r
added
the
improvement
Member
|
|
Member
Author
Member
dav3r
added
the
blocked
Member
Author
|
I labeled this PR as blocked until #22 gets taken care of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR updates some usage of
rules.ncats.cyber.dhs.govin tests to its successor,rules.vm.cyber.dhs.gov.💭 Motivation and context
Now that legacy subdomain
rules.ncats.cyber.dhs.govis an alias of the preferredrules.vm.cyber.dhs.govsubdomain, I figured we might as well try to eliminate all of our uses of the legacy subdomain.🧪 Testing
Running
pytestafter the changes in this PR showed that all tests were passing.✅ Pre-approval checklist