Skip to content

Bump Terraform merge upstream#2

Merged
felddy merged 14 commits intodevelopfrom
improvement/bump_tools
Nov 21, 2019
Merged

Bump Terraform merge upstream#2
felddy merged 14 commits intodevelopfrom
improvement/bump_tools

Conversation

@felddy
Copy link
Contributor

@felddy felddy commented Nov 21, 2019

🗣 Description

  • bump terraform version
  • pull in upstream changes

💭 Motivation and Context

@dav3r 
I guess someone used tf 0.12.15 in Production..... 

@jsf9k 
It was probably me. I’m ok with moving to 16.

Upstream merge to get CODEOWNERS, and action caching.

🧪 Testing

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

mcdonnnj and others added 14 commits November 2, 2019 19:48
@mcdonnnj
Re-enabled ansible-lint and ran pre-commit autoupgrade.
3c78dd9
@mcdonnnj
Merge pull request #21 from cisagov/pre-commit_autoupdate_2019-11-02
7dfd8bf 
Re-enable ansible-lint and autoupgrade.
@felddy
Add GitHub action caching of pre-commit hooks and pip packages.
5d5567d
@felddy
Merge branch 'develop' into improvement/action_cache
c26ea01
@felddy
Remove search for previous pre-commit caches.
99c6115 
These seem to be very large caches.  Restoring an old one and updating 
it results in a cache larger than the maximum allowed cache size: 200MB. 
 
"Cache size of 254757924 bytes is over the 200MB limit, not saving 
cache."
So if the config changes it is best to just take the cache-miss and 
start from scratch.
@felddy
Merge pull request #22 from cisagov/improvement/action_cache
10bbfdf 
Add GitHub action caching of pre-commit hooks and pip packages.
@felddy
Force pre-commit hooks to use python3.
7c0b30b 
Fixes #23
@felddy
Autoupdate pre-commit hooks.
30a16a3
@felddy
Merge pull request #24 from cisagov/improvement/pre_commit_default_py…
5e26930 
…thon

Set a default language for pre-commit hooks
@felddy
Add codeowners file with team OIS maintainers.
e39dc88 
See: 
https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
@felddy
Merge pull request #25 from cisagov/improvement/codeowners
3f93760 
Add codeowners file with team OIS maintainers.
@felddy
Update CODEOWNERS
b89eecb
@felddy
Bump terraform version.
7cd3d01 
See: 
https://github.com/hashicorp/terraform/blob/master/CHANGELOG.md#01216-november-18-2019
@felddy
Merge branch 'develop' of github.com:cisagov/skeleton-generic into im…
aa9b799 
…provement/bump_tools
@felddy felddy requested review from dav3r, jsf9k and mcdonnnj November 21, 2019 14:53
@felddy felddy self-assigned this Nov 21, 2019
dav3r
dav3r approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥊

jsf9k
jsf9k approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@felddy felddy merged commit c1b566d into develop Nov 21, 2019
@felddy felddy deleted the improvement/bump_tools branch November 21, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@felddy felddy

Labels

None yet

Projects

Skeleton Maintenance
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felddy @jsf9k @dav3r @mcdonnnj