Conversation
Workflow improvements: 🦁 set-env, and 🐯 python-3.9, and 🐻 dependabot, oh my!
cisagovbot
requested review from
dav3r,
felddy,
hillaryj,
jsf9k and
mcdonnnj
as code owners
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ Not sure if this is going to work in a Docker container. Will test.
Contributor
|
I am concerned about how this action sets environment variables. The GitHub no longer even document the ability to do this with outputs. I'm testing this branch now on a repo in my account. |
Contributor
Test was successful. This does work. |
felddy
approved these changes
Oct 7, 2020
Contributor
felddy
left a comment
felddy
left a comment
There was a problem hiding this comment.
Good to go. Git yo shirts @cisagovbot 👕 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-generic.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with
your project.
Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage