Merged
Conversation
This converts this Action to a `composite` Action from a `docker` Action. Since we only use this Action to provide version through outputs we do not need to go through the trouble of building and running a Docker image now that there are `composite` Actions: https://docs.github.com/en/actions/creating-actions/creating-a-composite-action This should simplify this Action greatly and reduce its run time.
mcdonnnj
added
the
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request converts this GitHub Action from a Docker container Action to a composite Action.
💭 Motivation and context
With the introduction of composite Actions we can do something as simple as this Action without needing to build and spin up a Docker image. Since cisagov/skeleton-generic#92 was merged we are already configured to use this Action's outputs so the change should be seamless.
🧪 Testing
Automated tests pass. I used this branch in this Actions run and saw the correct versions.
✅ Pre-approval checklist