Track the version of goimports to use in our projects#72
Merged
Conversation
mcdonnnj
added
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
approved these changes
Jan 20, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds version tracking for goimports.
💭 Motivation and context
In cisagov/skeleton-generic#163 we add installation of goimports for use with a pre-commit hook. It makes sense to track the version installed in GitHub Actions in this project along with similar tools.
🧪 Testing
Automated tests pass. This branch is used in the above PR without issue.
✅ Pre-approval checklist
to reflect the changes in this PR.