Skip to content

Convert this Action to use JavaScript#80

Merged
mcdonnnj merged 3 commits intodevelopfrom
improvement/convert_to_javascript_action
Dec 6, 2024
Merged

Convert this Action to use JavaScript#80
mcdonnnj merged 3 commits intodevelopfrom
improvement/convert_to_javascript_action

Conversation

@mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Dec 5, 2024

🗣 Description

This pull request changes this Action from a composite Action to a node20 Action written in JavaScript.

💭 Motivation and context

As we have added more tool versions this Action has become a little more cumbersome due to the composite Action structure. This change will allow us to store tool information in a more collected manner as well as allowing us to leverage actions/toolkit for any future capabilities we may like. I based the new structure on GitHub's sample JavaScript Action.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

This is the first step in converting this Action to a JavaScript one
from a composite Action.
This is necessary for the Action to actually run.
Fully convert the Action from a composite Action to a node Action.
@mcdonnnj mcdonnnj added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Dec 5, 2024
@mcdonnnj mcdonnnj self-assigned this Dec 5, 2024
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj merged commit 6e90189 into develop Dec 6, 2024
@mcdonnnj mcdonnnj deleted the improvement/convert_to_javascript_action branch December 6, 2024 05:26
mcdonnnj added a commit that referenced this pull request Mar 2, 2026
This was not done when this project was converted to a JavaScript
project in #80. This rectifies that oversight so Dependabot will update
the project's dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants