Skip to content

Add a release workflow#85

Merged
mcdonnnj merged 1 commit intodevelopfrom
improvement/add_release_workflow
May 15, 2025
Merged

Add a release workflow#85
mcdonnnj merged 1 commit intodevelopfrom
improvement/add_release_workflow

Conversation

@mcdonnnj
Copy link
Member

🗣 Description

This pull request adds the release workflow from cisagov/skeleton-action-composite.

💭 Motivation and context

This workflow will refresh the major and major.minor tags when a new release is cut and thus automating an otherwise manual task.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Add the release workflow from cisagov/skeleton-action-composite so that
the major and major.minor tags are updated when a new release is cut.
@mcdonnnj mcdonnnj requested review from a team and Copilot May 15, 2025 13:56
@mcdonnnj mcdonnnj self-assigned this May 15, 2025
@mcdonnnj mcdonnnj requested review from dav3r, felddy and jsf9k as code owners May 15, 2025 13:56
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code labels May 15, 2025
@mcdonnnj mcdonnnj enabled auto-merge May 15, 2025 13:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a GitHub Actions release workflow that automates refreshing both major and major.minor tags whenever a new release is created.

  • Introduces a new release workflow file with two jobs: diagnostics and release.
  • Uses semver extraction to derive version components and manages tag deletion and creation.

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copilot raises a good point, but no need to let it derail this PR. Make an issue (would be sweet if Copilot could do that for us) and move on.

@mcdonnnj mcdonnnj merged commit 26d53d1 into develop May 15, 2025
11 checks passed
@mcdonnnj mcdonnnj deleted the improvement/add_release_workflow branch May 15, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants