Skip to content

Exclude package-lock.json from pretty-format-json pre-commit hook#96

Merged
jsf9k merged 1 commit intodevelopfrom
improvement/exclude-package-lock.json
Feb 19, 2026
Merged

Exclude package-lock.json from pretty-format-json pre-commit hook#96
jsf9k merged 1 commit intodevelopfrom
improvement/exclude-package-lock.json

Conversation

@jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 22, 2026

🗣 Description

This pull request excludes package-lock.json from pretty-format-json pre-commit hook.

💭 Motivation and context

We can just let npm format this file however it wants to and avoid having to reformat it when Dependabot makes a pull request to update a dependency.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k self-assigned this Jan 22, 2026
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jan 22, 2026
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 22, 2026
@jsf9k jsf9k removed the dependencies Pull requests that update a dependency file label Jan 22, 2026
@jsf9k jsf9k marked this pull request as ready for review January 22, 2026 14:44
@jsf9k jsf9k enabled auto-merge January 22, 2026 14:44
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 22, 2026
@jsf9k jsf9k removed the dependencies Pull requests that update a dependency file label Jan 22, 2026
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just let npm format this file however it wants to.
@jsf9k jsf9k force-pushed the improvement/exclude-package-lock.json branch from 1ab18fc to 3902898 Compare February 19, 2026 15:37
@jsf9k jsf9k disabled auto-merge February 19, 2026 15:37
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 19, 2026
@jsf9k jsf9k merged commit a353aed into develop Feb 19, 2026
13 checks passed
@jsf9k jsf9k deleted the improvement/exclude-package-lock.json branch February 19, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants