Add support to build for the python3.10 Lambda runtime
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that a python3.10 runtime is available for Lambdas it makes sense to update the default to the latest version of Python in use.
mcdonnnj
added
improvement
jsf9k
approved these changes
Apr 24, 2023
dav3r
approved these changes
Apr 24, 2023
Comment on lines
+2
to
+4
| url = "https://pypi.org/simple" | ||
| verify_ssl = true | ||
| name = "pypi" |
There was a problem hiding this comment.
This is probably better as a separate PR, but we should alphabetize these per our usual standards:
Suggested change
| url = "https://pypi.org/simple" | |
| verify_ssl = true | |
| name = "pypi" | |
| name = "pypi" | |
| url = "https://pypi.org/simple" | |
| verify_ssl = true |
There was a problem hiding this comment.
If you're amenable I'll make a new branch + PR based on this branch fixing all four Pipfiles.
There was a problem hiding this comment.
Just mention the new PR here when it's created and then I'll resolve this conversation.
There was a problem hiding this comment.
This PR's work is going to be superseded by implementing #15. The suggestion here will be integrated into the PR that resolved the linked issue.
jasonodoom
approved these changes
May 3, 2023
jasonodoom
approved these changes
Jun 13, 2023
dv4harr10
approved these changes
Jul 25, 2023
|
This has been obsoleted by #35. |
github-project-automation
bot
moved this from Reviewer approved
to Done
in Skeleton Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds the necessary updates to build Python Lambda artifacts for the newly released
python3.10runtime. It also updates the Dockerfile to use Python 3.10 by default (from Python 3.9).💭 Motivation and context
We should support all of the Python runtimes that AWS actively offers for the lambda service. This will also allow Lambdas to take advantage of new Python features if so desired (as an example Python 3.10 added the
matchkeyword).🧪 Testing
Automated tests pass. I tested the Lambda image locally to verify functionality.
✅ Pre-approval checklist