Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ updates:
schedule:
interval: "weekly"

- package-ecosystem: "pip"
directory: "/src/py3.10"
schedule:
interval: "weekly"

- package-ecosystem: "terraform"
directory: "/"
schedule:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ jobs:
- "3.7"
- "3.8"
- "3.9"
- "3.10"
steps:
- uses: actions/checkout@v3
- name: Get the short SHA for the commit being used
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ARG PY_VERSION=3.9
ARG PY_VERSION=3.10

FROM amazon/aws-lambda-python:$PY_VERSION as install-stage

# Declare it a second time so it's brought into this scope.
ARG PY_VERSION=3.9
ARG PY_VERSION=3.10

# Install the Python packages necessary to install the Lambda dependencies.
RUN python3 -m pip install --no-cache-dir \
Expand Down Expand Up @@ -41,7 +41,7 @@ LABEL org.opencontainers.image.authors="github@cisa.dhs.gov"
LABEL org.opencontainers.image.vendor="Cybersecurity and Infrastructure Security Agency"

# Declare it a third time so it's brought into this scope.
ARG PY_VERSION=3.9
ARG PY_VERSION=3.10

# This must be present in the image to generate a deployment artifact.
ENV BUILD_PY_VERSION=$PY_VERSION
Expand Down
11 changes: 11 additions & 0 deletions src/py3.10/Pipfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"
Comment on lines +2 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably better as a separate PR, but we should alphabetize these per our usual standards:

Suggested change
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're amenable I'll make a new branch + PR based on this branch fixing all four Pipfiles.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just mention the new PR here when it's created and then I'll resolve this conversation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR's work is going to be superseded by implementing #15. The suggestion here will be integrated into the PR that resolved the linked issue.


[requires]
python_version = "3.10"

[packages]
cowsay = "*"
example = {file = "https://github.com/cisagov/skeleton-python-library/archive/v0.1.0.tar.gz"}
64 changes: 64 additions & 0 deletions src/py3.10/Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.