Added SNMP Notification Receiver

[jonnytdevops]

This is currently failing rubocop on the following:

lib/cisco_node_utils/snmp_notification_receiver.rb:24:5: C: Assignment Branch Condition size for initialize is too high. [41.61/40]
    def initialize(name,
    ^^^
lib/cisco_node_utils/snmp_notification_receiver.rb:24:5: C: Cyclomatic complexity for initialize is too high. [20/17]
    def initialize(name,
    ^^^
lib/cisco_node_utils/snmp_notification_receiver.rb:24:5: C: Perceived complexity for initialize is too high. [20/19]

However, this needs to be changed in the upstream rubocop code. My current code for this class is appropriate for the task, and is in line with other the other classes that has been merged.

[glennmatthews]

You can change lib/.rubocop.yml to add the appropriate new upper bounds for these metrics as part of this PR.

Alternately, consider splitting the argument validation into a separate validation function - see snmpuser.rb for an example.

[glennmatthews]

Consider using named args instead:

def initialize(name,
               instantiate: true, type: '', version: '', security: '', username: '',
               port: '', vrf: '', source_interface: '')

This will make the instantiation calls easier to read and less error prone:

    receiver = Cisco::SnmpNotificationReceiver.new(
      id,
      instantiate:      true,
      type:             'informs',
      version:          '3',
      security:         'priv',
      username:         'ab',
      port:             '45',
      vrf:              'red',
      source_interface: 'ethernet1/3')

[jonnytdevops]

@glennmatthews @mikewiebe Can this please be merged, the code has been updated, thanks

[glennmatthews]

missing space between * and SNMP is causing the markdown to render this as italics instead of a bullet list - please fix.

[jonnytdevops]

@glennmatthews @chrisvanheuveln @mikewiebe Happy New Year! I've made the requested changes. It would be appreciated if this could be merged. Thanks

[glennmatthews]

👍