Feature/pc #150

saichint · 2015-12-22T19:12:50Z

interface_port_channel and portchannel_global nodeutils added.

rubocop run:

[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ rubocop ../lib/cisco_node_utils/interface_port_channel.rb ../lib/cisco_node_utils/portchannel_global.rb test_interface_port_channel.rb test_portchannel_global.rb
warning: parser/current is loading parser/ruby21, which recognizes
warning: 2.1.7-compliant syntax, but you are running 2.1.1.
Inspecting 4 files
....

4 files inspected, no offenses detected

mini-test results:

[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_portchannel_global.rb 10.122.197.117 admin admin
Run options: --seed 64148

Running:

Node under test:

name - agent-lab13-nx
type - N9K-NXOSV
image - bootflash:///nxos.7.0.3.I2.1.bin

......

Finished in 25.962281s, 0.2311 runs/s, 0.4622 assertions/s.

6 runs, 12 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.

[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_portchannel_global.rb 172.23.148.240 admin nbv_12345
Run options: --seed 54426

Running:

Node under test:

name - switch
type - N7K-C7010
image - bootflash:///n7000-s2-dk9.7.3.0.D1.0.179.gbin

......

Finished in 15.348295s, 0.3909 runs/s, 0.7818 assertions/s.

6 runs, 12 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.

[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_portchannel_global.rb 10.122.84.77 admin nbv_1234
Run options: --seed 56569

Running:

Node under test:

name - n6k-77
type - N6K-C6001-64P
image - bootflash:///n6000-uk9-kickstart.7.3.0.ZN.0.208.bin

......

Finished in 26.315032s, 0.2280 runs/s, 0.3420 assertions/s.

6 runs, 9 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.

[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_interface_port_channel.rb 10.122.197.117 admin admin
Run options: --seed 38297

Running:

Node under test:

name - agent-lab13-nx
type - N9K-NXOSV
image - bootflash:///nxos.7.0.3.I2.1.bin

......

Finished in 46.036638s, 0.1303 runs/s, 0.2824 assertions/s.

6 runs, 13 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.
[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_interface_port_channel.rb 172.23.148.240 admin nbv_12345
Run options: --seed 26005

Running:

Node under test:

name - switch
type - N7K-C7010
image - bootflash:///n7000-s2-dk9.7.3.0.D1.0.179.gbin

......

Finished in 15.467798s, 0.3879 runs/s, 0.8405 assertions/s.

6 runs, 13 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.
[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_interface_port_channel.rb 10.122.84.77 admin nbv_1234
Run options: --seed 34278

Running:

Node under test:

name - n6k-77
type - N6K-C6001-64P
image - bootflash:///n6000-uk9-kickstart.7.3.0.ZN.0.208.bin

......

Finished in 27.581864s, 0.2175 runs/s, 0.2900 assertions/s.

6 runs, 8 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.

chrisvanheuveln · 2015-12-22T19:32:17Z

CHANGELOG.md

We should be consistent on these names - please choose port_channel or portchannel.

…k-node-utils into feature/pc

saichint · 2015-12-23T18:56:53Z

test results

[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_interface_portchannel.rb 10.122.197.117 admin admin
Run options: --seed 5623

Running:

Node under test:

name - agent-lab13-nx
type - N9K-NXOSV
image - bootflash:///nxos.7.0.3.I2.1.bin

......

Finished in 46.916949s, 0.1279 runs/s, 0.2771 assertions/s.

6 runs, 13 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.
[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_interface_portchannel.rb 172.23.148.240 admin nbv_12345
Run options: --seed 14099

Running:

Node under test:

name - switch
type - N7K-C7010
image - bootflash:///n7000-s2-dk9.7.3.0.D1.0.179.gbin

......

Finished in 15.384674s, 0.3900 runs/s, 0.8450 assertions/s.

6 runs, 13 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.

[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_interface_portchannel.rb 10.122.84.77 admin nbv_1234
Run options: --seed 6087

Running:

Node under test:

name - n6k-77
type - N6K-C6001-64P
image - bootflash:///n6000-uk9-kickstart.7.3.0.ZN.0.208.bin

....SS

Finished in 28.213186s, 0.2127 runs/s, 0.2836 assertions/s.

6 runs, 8 assertions, 0 failures, 0 errors, 2 skips

You have skipped tests. Run with --verbose for details.
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.

[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_portchannel_global.rb 10.122.84.77 admin nbv_1234
Run options: --seed 63370

Running:

Node under test:

name - n6k-77
type - N6K-C6001-64P
image - bootflash:///n6000-uk9-kickstart.7.3.0.ZN.0.208.bin

SSSSS.

Finished in 26.248570s, 0.2286 runs/s, 0.3429 assertions/s.

6 runs, 9 assertions, 0 failures, 0 errors, 5 skips

You have skipped tests. Run with --verbose for details.
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.
[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_portchannel_global.rb 10.122.197.117 admin admin
Run options: --seed 26924

Running:

Node under test:

name - agent-lab13-nx
type - N9K-NXOSV
image - bootflash:///nxos.7.0.3.I2.1.bin

..SSSS

Finished in 28.430601s, 0.2110 runs/s, 0.4221 assertions/s.

6 runs, 12 assertions, 0 failures, 0 errors, 4 skips

You have skipped tests. Run with --verbose for details.
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.
[saichint@sjc-ads-6603 /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests] $ ruby test_portchannel_global.rb 172.23.148.240 admin nbv_12345
Run options: --seed 40856

Running:

Node under test:

name - switch
type - N7K-C7010
image - bootflash:///n7000-s2-dk9.7.3.0.D1.0.179.gbin

.SSS..

Finished in 16.368702s, 0.3666 runs/s, 0.7331 assertions/s.

6 runs, 12 assertions, 0 failures, 0 errors, 3 skips

You have skipped tests. Run with --verbose for details.
Coverage report generated for MiniTest to /ws/saichint-sjc/puppet_agent/cisco-network-node-utils/tests/coverage. 0.0 / 0.0 LOC (100.0%) covered.

Feature/pc

sai chintalapudi added 2 commits December 22, 2015 11:03

interface_port_channel and portchannel_global addition

9b49d10

Update CHANGELOG.md

8966e1f

chrisvanheuveln reviewed Dec 22, 2015
View reviewed changes

CHANGELOG.md Outdated

Copy link

Contributor

chrisvanheuveln Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consistent on these names - please choose port_channel or portchannel.

chrisvanheuveln self-assigned this Dec 22, 2015

saichint added 6 commits December 22, 2015 15:12

Update CHANGELOG.md

fdba9f3

pull req comments

fb1c5af

pull req comments

0f7c84c

Merge branch 'feature/pc' of https://github.com/saichint/cisco-networ…

b8c2ead

…k-node-utils into feature/pc

review comment

bdb3ce4

conflict cleaned

fffa805

removed optional space from hash distribution

7478ab9

chrisvanheuveln added a commit that referenced this pull request Dec 23, 2015

Merge pull request #150 from saichint/feature/pc

4f7f42c

Feature/pc

chrisvanheuveln merged commit 4f7f42c into cisco:develop Dec 23, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/pc #150

Feature/pc #150

Uh oh!

saichint commented Dec 22, 2015

Uh oh!

chrisvanheuveln Dec 22, 2015

Uh oh!

saichint commented Dec 23, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Feature/pc #150

Feature/pc #150

Uh oh!

Conversation

saichint commented Dec 22, 2015

rubocop run:

mini-test results:

Running:

Running:

Running:

Running:

Running:

Running:

Uh oh!

chrisvanheuveln Dec 22, 2015

Choose a reason for hiding this comment

Uh oh!

saichint commented Dec 23, 2015

test results

Running:

Running:

Running:

Running:

Running:

Running:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants