-
Notifications
You must be signed in to change notification settings - Fork 50
api & test cleanups for platform differences #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api & test cleanups for platform differences #151
Conversation
…ode-utils into smigopal-develop
Most of these changes are cleanups for enabling features and adding checks for feature support.
These changes allow for testing on N3,N7,N9. There are still several failures on N7 that are unrelated to my changes, such as the inability to do 'no switchport'. Test results from affected tests: --- test_interface.rb N7: 44 runs, 44 assertions, 10 failures, 14 errors, 1 skips (failures unrelated to my changes) N9: 44 runs, 320 assertions, 0 failures, 0 errors, 2 skips N3: 44 runs, 343 assertions, 0 failures, 0 errors, 5 skips --- test_interface_service.rb N7: 4 runs, 23 assertions, 0 failures, 0 errors, 0 skips N39: 4 runs, 0 assertions, 0 failures, 0 errors, 4 skips --- test_interface_svi.rb N7: N39: 19 runs, 46 assertions, 0 failures, 0 errors, 0 skips --- test_interface_switchport.rb N7: 53 runs, 59 assertions, 5 failures, 6 errors, 0 skips (failures unrelated to my changes) N39:53 runs, 97 assertions, 0 failures, 0 errors, 0 skips --- test_platform.rb N7: 14 runs, 16 assertions, 3 failures, 0 errors, 1 skips (failures unrelated to my changes) N39: 14 runs, 19 assertions, 0 failures, 0 errors, 0 skips --- test_vdc.rb N7: 3 runs, 6 assertions, 0 failures, 0 errors, 0 skips N39:3 runs, 0 assertions, 0 failures, 0 errors, 3 skips --- test_vni.rb N7: 3 runs, 7 assertions, 0 failures, 0 errors, 1 skips N39: 3 runs, 8 assertions, 0 failures, 0 errors, 2 skips --- test_vlan.rb N7: 21 runs, 44 assertions, 0 failures, 3 errors, 0 skips (failures unrelated to my changes) N9: 21 runs, 45 assertions, 0 failures, 0 errors, 1 skips N3: 21 runs, 45 assertions, 0 failures, 0 errors, 1 skips --- test_vtp.rb N7: 31 runs, 123 assertions, 2 failures, 0 errors, 0 skips (failures unrelated to my changes) N39: 31 runs, 123 assertions, 0 failures, 0 errors, 0 skips --- test_vrf.rb N7: 8 runs, 17 assertions, 0 failures, 1 errors, 1 skips (failures unrelated to my changes) N9: 8 runs, 21 assertions, 0 failures, 0 errors, 0 skips N3: 8 runs, 19 assertions, 0 failures, 0 errors, 1 skips --- test_vxlan_vtep.rb N7: 7 runs, 54 assertions, 0 failures, 0 errors, 0 skips N9: 7 runs, 22 assertions, 0 failures, 0 errors, 1 skips N3: 7 runs, 19 assertions, 0 failures, 0 errors, 2 skips --- test_router_bgp.rb N7: 62 runs, 227 assertions, 1 failures, 0 errors, 2 skips N9: 62 runs, 235 assertions, 0 failures, 0 errors, 0 skips N3: 62 runs, 231 assertions, 0 failures, 1 errors, 0 skips (failures unrelated to my changes) --- test_bgp_neighbor.rb N7: 22 runs, 206 assertions, 0 failures, 1 errors, 0 skips (failures unrelated to my changes) N39: 22 runs, 220 assertions, 0 failures, 0 errors, 0 skips ---
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about 5k and 6k ? Are they mt full or lite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You tell me :-)
I thought 5/6k were neither at the moment but getting support for mt full at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked with my team, 5k/6k are mt-lite, so you may wanna add them under mt-lite here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My n56128P switch does not seem to support it:
n8k-136(config)# feature nv overlay
Error: feature nv overlay failed dependencies not satisfied yet
n8k-136(config)# feature vn-segment-vlan-based
Error: vnseg_vlan control, vn-segment depends on feature-set fabricpath or feature nv overlay (0x411000bd)
If this is a license issue, how do I get around it? ie. how to check the current license; and how to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the license guide:
http://www.cisco.com/c/en/us/td/docs/switches/datacenter/sw/nx-os/licensing/guide/b_Cisco_NX-OS_Licensing_Guide/b_Cisco_NX-OS_Licensing_Guide_chapter_01.html
For now though, I suggest to add a story to backlog for adding mt-lite puppet support for 5/6k. We can look at it when we test 5/6k
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add 5k, 6k under mt-lite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defer to US 62787.
api & test cleanups for platform differences
Test results from affected tests: