Adding property - fabric forwarding mode anycast-gateway, to Cisco_Interface #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/cisco_node_utils/interface.rb
Outdated
| no_cmd = (state ? '' : 'no') | ||
| config_set('interface', | ||
| 'fabric_forwarding_anycast_gateway', @name, no_cmd) | ||
| expected_state = state |
Contributor
There was a problem hiding this comment.
This line expected_state = state is unnecessary. Just use state.
Contributor
|
@smigopal, @glennmatthews is refactoring VxlanGlobal a bit which will result in a few changes to this code as well. He should have a PR out soon, but let's wait on that before we continue with this code review. |
Member
|
See #220 |
lib/cisco_node_utils/interface.rb
Outdated
| end | ||
|
|
||
| def fabric_forwarding_anycast_gateway=(state) | ||
| begin |
Member
There was a problem hiding this comment.
begin...end is unnecessary here.
| fail TypeError unless mac_addr.is_a?(String) | ||
|
|
||
| Feature.nv_overlay_evpn_enable unless Feature.nv_overlay_evpn_enabled? | ||
| Feature.nv_overlay_evpn_enable |
mikewiebe
added a commit
that referenced
this pull request
Feb 11, 2016
Adding property - fabric forwarding mode anycast-gateway, to Cisco_Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Supporting property fabric forwarding mode anycast-gateway under Interface
Minitests:
rtpfe1@agent-lab11-ws:~/smigopal/feb_interface/cisco-network-node-utils$ ruby tests/test_interface.rb -v -n test_interface_fabric_forwarding_anycast_gateway -- 10.122.197.125 admin admin
Run options: -v -n test_interface_fabric_forwarding_anycast_gateway -- --seed 26306
Running:
Node under test:
conf : ["interface vlan11"]
conf : [" fabric forwarding anycast-gateway-mac 1223.3445.5668"]
conf : ["interface vlan11", "no fabric forwarding mode anycast-gateway"]
conf : ["interface vlan11", " fabric forwarding mode anycast-gateway"]
conf : ["interface vlan11", "no fabric forwarding mode anycast-gateway"]
conf : ["no fabric forwarding anycast-gateway-mac "]
conf : ["interface vlan11", " fabric forwarding mode anycast-gateway"]
conf : ["feature fabric forwarding"]
conf : ["interface vlan11", " fabric forwarding mode anycast-gateway"]
conf : ["interface ethernet1/1"]
conf : ["interface ethernet1/1", " fabric forwarding mode anycast-gateway"]
TestInterface#test_interface_fabric_forwarding_anycast_gateway = 10.29 s = .
Finished in 10.289229s, 0.0972 runs/s, 0.5831 assertions/s.
1 runs, 6 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /home/rtpfe1/smigopal/feb_interface/cisco-network-node-utils/coverage. 669 / 1287 LOC (51.98%) covered.
rtpfe1@agent-lab11-ws:~/smigopal/feb_interface/cisco-network-node-utils$
Rubocop:
rtpfe1@agent-lab11-ws:~/smigopal/feb_interface/cisco-network-node-utils$ rubocop tests/test_interface.rb
warning: parser/current is loading parser/ruby22, which recognizes
warning: 2.2.3-compliant syntax, but you are running 2.2.1.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Inspecting 1 file
.
1 file inspected, no offenses detected
rtpfe1@agent-lab11-ws:~/smigopal/feb_interface/cisco-network-node-utils$ rubocop lib/cisco_node_utils/interface.rb
warning: parser/current is loading parser/ruby22, which recognizes
warning: 2.2.3-compliant syntax, but you are running 2.2.1.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Inspecting 1 file
.
1 file inspected, no offenses detected
rtpfe1@agent-lab11-ws:~/smigopal/feb_interface/cisco-network-node-utils$