Skip to content

Conversation

@mikewiebe
Copy link
Contributor

  • De-couples nv overlay evpn from feature fabric fowarding.
  • Add call in overlay_global.rb, anycast_gateway_mac setter method to enable both nv overlay evpn and feature fabric forwarding but feature fabric forwarding is a no-op on images that don't support it.
  • Refactored tests.

TESTS

rtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils> ruby tests/test_interface.rb -n test_interface_fabric_forwarding_anycast_gateway -v -- dt-n9k5-1 admin admin
Run options: -n test_interface_fabric_forwarding_anycast_gateway -v -- --seed 21871

# Running:


Node under test:
  - name  - dt-n9k5-1
  - type  - N9K-C9396PX
  - image - bootflash:///nxos.7.0.3.I3.1.bin

TestInterface#test_interface_fabric_forwarding_anycast_gateway = 13.94 s = .

Finished in 13.939495s, 0.0717 runs/s, 0.3587 assertions/s.

1 runs, 5 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils/coverage. 689 / 1290 LOC (53.41%) covered.
rtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils> ruby tests/test_interface.rb -n test_interface_fabric_forwarding_anycast_gateway -v -- agent-lab10-nx admin admin
Run options: -n test_interface_fabric_forwarding_anycast_gateway -v -- --seed 35363

# Running:


Node under test:
  - name  - agent-lab10-nx
  - type  - N9K-NXOSV
  - image - bootflash:///nxos.7.0.3.I2.1.bin

TestInterface#test_interface_fabric_forwarding_anycast_gateway = 9.49 s = .

Finished in 9.493716s, 0.1053 runs/s, 0.5267 assertions/s.

1 runs, 5 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils/coverage. 687 / 1290 LOC (53.26%) covered.
rtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils> 
rtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils> ruby tests/test_overlay_global.rb  -v -- dt-n9k5-1 admin admin
Run options: -v -- --seed 6791

# Running:


Node under test:
  - name  - dt-n9k5-1
  - type  - N9K-C9396PX
  - image - bootflash:///nxos.7.0.3.I3.1.bin

TestOverlayGlobal#test_dup_host_ip_addr_detection = 10.44 s = .
TestOverlayGlobal#test_anycast_gateway_mac = 10.66 s = .
TestOverlayGlobal#test_dup_host_mac_detection = 6.55 s = .

Finished in 27.649013s, 0.1085 runs/s, 0.7234 assertions/s.

3 runs, 20 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils/coverage. 655 / 1244 LOC (52.65%) covered.
rtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils> 
rtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils> ruby tests/test_overlay_global.rb  -v -- agent-lab10-nx admin admin
Run options: -v -- --seed 21989

# Running:


Node under test:
  - name  - agent-lab10-nx
  - type  - N9K-NXOSV
  - image - bootflash:///nxos.7.0.3.I2.1.bin

TestOverlayGlobal#test_dup_host_mac_detection = 4.62 s = .
TestOverlayGlobal#test_dup_host_ip_addr_detection = 3.56 s = .
TestOverlayGlobal#test_anycast_gateway_mac = 4.76 s = .

Finished in 12.937798s, 0.2319 runs/s, 1.5459 assertions/s.

3 runs, 20 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for MiniTest to /nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils/coverage. 649 / 1244 LOC (52.17%) covered.
rtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/release120/cisco-network-node-utils> 

fail if fabric_forwarding_anycast_gateway.to_s != state.to_s
rescue Cisco::CliError => e
info = "[#{@name}] '#{e.command}' : #{e.clierror}"
raise "#{info} 'fabric_forwarding_anycast_gateway' can ony be " \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ony/only/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

chrisvanheuveln added a commit that referenced this pull request Feb 11, 2016
@chrisvanheuveln chrisvanheuveln merged commit 740f3d4 into release_1.2.0 Feb 11, 2016
@robert-w-gries robert-w-gries deleted the rel/vxlan_fabric_fixes branch July 27, 2016 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants