Refactor crypto_openssl3 to use return types internally#76
Merged
bifurcation merged 3 commits intocisco:mainfrom Mar 9, 2026
Merged
Refactor crypto_openssl3 to use return types internally#76bifurcation merged 3 commits intocisco:mainfrom
bifurcation merged 3 commits intocisco:mainfrom
Conversation
bifurcation
approved these changes
Mar 6, 2026
| { | ||
| auto mode = EVP_KDF_HKDF_MODE_EXTRACT_ONLY; | ||
| auto digest_name = openssl_digest_name(suite); | ||
| auto digest_name = SFRAME_VALUE_OR_THROW(openssl_digest_name(suite)); |
Contributor
There was a problem hiding this comment.
I'll allow this for now, in order to avoid changing the crypto.h method signatures. But we should ultimately not have any _OR_THROW except in the public API.
src/crypto_openssl3.cpp
Outdated
Comment on lines
+41
to
+42
| return Result<const EVP_CIPHER*>::err( | ||
| SFrameErrorType::unsupported_ciphersuite_error); |
Contributor
There was a problem hiding this comment.
All of these Result::err calls get kind of verbose. I wonder if it would be worth making an abbreviation macro, something like:
Suggested change
| return Result<const EVP_CIPHER*>::err( | |
| SFrameErrorType::unsupported_ciphersuite_error); | |
| return SFRAME_ERROR(const EVP_Cipher*, unsupported_ciphersuite_error); |
Contributor
There was a problem hiding this comment.
Actually, now that I think of it, the Error constructor pretty much makes err() and ok() unnecessary. You can just return SFrameErrorType::unsupported_ciphersuite_error and those handy C++ implicit conversion rules will take care of things for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.