Collapse, ExpansionPanel and Accordion components#101
Merged
pixelbandito merged 5 commits intocision:masterfrom Sep 10, 2019
Merged
Collapse, ExpansionPanel and Accordion components#101pixelbandito merged 5 commits intocision:masterfrom
pixelbandito merged 5 commits intocision:masterfrom
Conversation
rheckart
approved these changes
Sep 3, 2019
rheckart
left a comment
rheckart
left a comment
There was a problem hiding this comment.
Looks good to me! Will be interested in any thoughts that the primary stakeholders have.
pixelbandito
suggested changes
Sep 3, 2019
Contributor
|
👏 👏 👏 |
mdespuits
suggested changes
Sep 4, 2019
Contributor
mdespuits
left a comment
mdespuits
left a comment
There was a problem hiding this comment.
Loving all of the tests! A few suggestions for sharing children prop types but otherwise looks 👍
pixelbandito
approved these changes
Sep 4, 2019
Contributor
pixelbandito
left a comment
pixelbandito
left a comment
There was a problem hiding this comment.
Left a small, optional note.
hpieroni
force-pushed
the
expansion-panel-component
branch
from
d5cff94 to
8e0d8db
Compare
mdespuits
approved these changes
Sep 9, 2019
| </section> | ||
| <section> | ||
| <h1>Accordion</h1> | ||
| <Accordion> |
Contributor
There was a problem hiding this comment.
You didn't import Accordion. :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr includes the following components:
ChevroniconCollapse: wrapsTransitioncomponent from react-transition-group and animates height.ExpansionPanel: includes a header (with an optional icon) and a body that is collapsed/expanded viaCollapsecomponent. It could be a controlled or uncontrolled component.Accordion: receives multipleExpansionPanelcomponents as children and allows only one of them to be expanded at the same time.