Conversation
|
Before I look closely at the existing Icon components, it's worth mentioning that this may be a good opportunity to talk about using @chelshaw @pixelbandito thoughts? |
|
@nvmusoke I'd be happy to approve this, but I agree that you should run those icons through svgo first. I remember it being pretty easy, but let me or @mdespuits know if you need a hand. |
|
@mdespuits @pixelbandito yeah i'm gonna run them through svgo. I tested it in a new branch and it was really simple. |
chelshaw
left a comment
There was a problem hiding this comment.
A few updates
What are all the files in /Icon/main for?
All the svgs i've yet to make js files for. I initially added them because i thought I needed them, but then I thought it would be easier to keep them in the same project. |
|
My initial preference is not to keep working .svg files in the codebase, but I can see how it's a helpful way to keep track of what's left to do. I'm ok with it. |
other devs seem fine with keeping svg files in.
updated existing icons & created new icons using icons from designer provided folder.