Conversation
Contributor
|
Can you document the breaking changes here, and we can copy them over into the version tag notes? |
Contributor
Author
Not sure what you're referring to. This makes me think we need to introduce a |
chelshaw
approved these changes
Nov 4, 2019
Contributor
|
👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
styled-componentfromPaperandBadgecomponents for simpler dependencies.Breaking changes
styled-systemproperties such as<Paper p={0}>will no longer work. Thepattribute was part of styled system. These theme-related attributes will no longer be supported. Moving forward any use ofPaperthat requires style changes other than through the provided prop flags will need to be done throughclassNameorstyleprops. There are only a small handful (4-5) of places in the main FE application that use these properties since we have bene favoring any styling throughclassNameand/orstyle. I've already identified them and prepared for this switch out so this will not be a major issue<Badge>from Rover was not yet used in the main FE app, so as far our app is concerned this is not an issue