Skip to content

Version Bump: v0.1.0-alpha.26#127

Merged
mdespuits merged 1 commit intomasterfrom
alpha.26
Nov 4, 2019
Merged

Version Bump: v0.1.0-alpha.26#127
mdespuits merged 1 commit intomasterfrom
alpha.26

Conversation

@mdespuits
Copy link
Copy Markdown
Contributor

@mdespuits mdespuits commented Oct 28, 2019

Changes:

  • Removes styled-component from Paper and Badge components for simpler dependencies.

Breaking changes

  • styled-system properties such as <Paper p={0}> will no longer work. The p attribute was part of styled system. These theme-related attributes will no longer be supported. Moving forward any use of Paper that requires style changes other than through the provided prop flags will need to be done through className or style props. There are only a small handful (4-5) of places in the main FE application that use these properties since we have bene favoring any styling through className and/or style. I've already identified them and prepared for this switch out so this will not be a major issue
  • <Badge> from Rover was not yet used in the main FE app, so as far our app is concerned this is not an issue

@pixelbandito
Copy link
Copy Markdown
Contributor

Can you document the breaking changes here, and we can copy them over into the version tag notes?

@mdespuits
Copy link
Copy Markdown
Contributor Author

copy them over into version tag notes?

Not sure what you're referring to. This makes me think we need to introduce a CHANGELOG.md

@mdespuits mdespuits changed the title Version Bump: v0.2.0 Version Bump: v0.1.0-alpha.26 Nov 4, 2019
@mdespuits mdespuits merged commit 54bce53 into master Nov 4, 2019
@mdespuits mdespuits deleted the alpha.26 branch November 4, 2019 17:39
@pixelbandito
Copy link
Copy Markdown
Contributor

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants