Update button color, add text-decoration none, rename CSS variable#130
Update button color, add text-decoration none, rename CSS variable#130pixelbandito merged 2 commits intomasterfrom
Conversation
mdespuits
left a comment
mdespuits
left a comment
There was a problem hiding this comment.
The prop-types declaration is in the wrong place. Other than the one question, looks good!
| yarn-error.log* | ||
| storybook-static | ||
| .yalc | ||
| yalc.lock |
There was a problem hiding this comment.
yalc solves the same problem as yarn link/npm link, but it actually copies deps and maintains a sort of local package registry.
https://github.com/whitecolor/yalc
It works more like real dependencies, and, in this case, solved some issues with peer deps when I was trying to test local front-ends importing local RoverUI.
However, I haven't figured out the best options to use it with, so I had to let it make changes to my front-end code's package.json file. Not ideal, long term, so I haven't documented it as a "solution" for local testing.
I wanted to add it to .gitignore, because I anticipate using it for testing again and this reduces the risk of me pushing local registry metadata to git.
2 participants
This is a patch version, since it doesn't add any functionality, it just fixes a bug and cleans up internal workings.
Updated primary button color to Cision green-ish blue. (Bug fix)
text-decoration: nonefor when a button uses anaorLinkas the tag. (Bug fix)CSS var name cleanup (
--rvr-rvr-*->--rvr-*)Made example app use the same package versions as the parent by default, hopefully that will squash some of the security warnings on the github repo.
Added yalc to .gitignore. I used yalc to test locally, but I'm not confident enough yet to add instructions to the README. I will once I have the process down.