Added Button level 'text' and added yalc note to README.md#133
Added Button level 'text' and added yalc note to README.md#133pixelbandito merged 2 commits intomasterfrom
Conversation
chelshaw
left a comment
There was a problem hiding this comment.
Looks good, thanks for the yalc instructions
mdespuits
left a comment
There was a problem hiding this comment.
Looking good. Had a few suggestions but nothing blocking.
| .text, | ||
| .text:link, | ||
| .text:visited { | ||
| color: var(--rvr-color-text); |
There was a problem hiding this comment.
Instead of re-declaring the properties and the values, you should be able to declare a component variable that you can re-assign in the scope. For example:
.text {
--rvr-btn-color: var(--rvr-color-text);
color: var(--rvr-btn-color); /* sets the default */
}
.text:active {
/* Changes the variable for the scope, but no property declaration necessary */
--rvr-btn-color: var(--rvr-color-text-active);
}There was a problem hiding this comment.
Also, this is not a blocker, but more of a bikeshed thought about how to build out these variants
There was a problem hiding this comment.
I like this idea, but without spending some time trying to dedupe styles, it doesn't seem like an obvious improvement in this component (since the variables-to-style rules ratio is 1:1).
I'll think about approaches to drying this up, and If I'm missing something, please let me know. For now, I'd like to merge as-is.
| 'secondary', | ||
| 'success', | ||
| 'teal', | ||
| 'teal', |
61dec5b to
5d9c96a
Compare
b346f3d to
9536350
Compare
9536350 to
c051196
Compare
Added .yalc instructions with a big warning to the README.
Added a "Text" level to button that looks like blue text, no border. I did this because:
I figured "text" was a little less confusing than "link" as a modifier, since these don't get typical underline styles.
I also figured I'd leave the padding / sizing as it is, following Bootstrap/Foundation, and ppl can override the styles with
padding: 0when/if necessary.I don't know what to do as far as naming convention to add the gray and blue variations. (Request for comments)