Correct pill font#148
Conversation
|
Hey, @kcj002 any reason not to put the new font in the |
|
I thought the |
Ah, I missed that because it's not supposed to be in |
| @@ -1,10 +1,11 @@ | |||
| :root { | |||
| font-family: 'Proxima Nova', sans-serif; | |||
There was a problem hiding this comment.
Sorry I didn't realize that was a style rule in colors.css - I thought it was a CSS variable.
Safe to just omit it, but it shouldn't hurt anything.
There was a problem hiding this comment.
So I can remove this from variables and colors.css and then recreate the font variable and use that for Menu.Item and Pill
There was a problem hiding this comment.
Yes, exactly. If/when we want to apply a font-family to a component, we should re-add it to variables.css
If you want to do that now, great, but it can also wait if necessary.
6c00a0d to
0cf5fb7
Compare
Pill font styling was Source Sans Pro, which was TrendKite styling. Post rebrand, Source Sans Pro was replaced with Proxima Nova. Removed styling for Menu.Item and Pill so that global font of Proxima Nova would be used.
Risk: low, just a font update.