Consolidate shared colors.css#154
Merged
pixelbandito merged 1 commit intomasterfrom Apr 2, 2020
Merged
Conversation
pixelbandito
commented
Mar 23, 2020
| @@ -0,0 +1,103 @@ | |||
| const colorNamesMap = { | |||
Contributor
Author
There was a problem hiding this comment.
This part feels like overkill.
Longer term, I'd like to configure postcss-custom-properties to create js files from our shared css variable files, and maybe build the story from that.
That will require a bit of digging, but I mostly didn't do it now because I don't want to create confusion with the existing shared/colors.js until @mdespuits and I have confirmed it's not being used anywhere.
…c colors that matches Figma
pixelbandito
force-pushed
the
realign-design-system-colors
branch
from
fd77175 to
11b021c
Compare
dkordik
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...into one palette and one set of semantic colors that matches Figma.
Added story to document the color set.