Skip to content

Deploy GH Pages Workflow#162

Merged
mdespuits merged 5 commits intomasterfrom
deploy-gh-pages-workflow
Apr 23, 2020
Merged

Deploy GH Pages Workflow#162
mdespuits merged 5 commits intomasterfrom
deploy-gh-pages-workflow

Conversation

@mdespuits
Copy link
Copy Markdown
Contributor

Uses a pre-built Github Workflow action to deploy our GitHub pages documentation.

@pixelbandito
Copy link
Copy Markdown
Contributor

If I understand it right, after this change pushing to master will auto-deploy the storybook documentation site.

Since the gh-page is the API documentation for the npm package, would it make sense to only/always update it when the npm package is published? Is it possible to trigger a git workflow based on pushing a new tag that matches a pattern, like v[0-9] or v*?

@pixelbandito
Copy link
Copy Markdown
Contributor

It would be cool to auto-incrementing the version and npm publish on every push to master by default, but then we'd need to select major/minor/patch on every push to master.

(There was an npm package we looked at that did this, iirc.)

@mdespuits mdespuits marked this pull request as ready for review April 22, 2020 14:26
@mdespuits
Copy link
Copy Markdown
Contributor Author

@pixelbandito Both of those suggestions are fantastic. And yes, they are both attainable. I figured until we could put that setup together, it would be worth having the documentation updates automatically and we could drop the need for the dev dependency altogether.

In any case, I'd like to get this in for now and revisit that flow on Monday now that we have a CI/CD pipeline we can use.

@mdespuits mdespuits merged commit bb9e727 into master Apr 23, 2020
@mdespuits mdespuits deleted the deploy-gh-pages-workflow branch April 23, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants